servicecatalog / oscm-approval

OSCM Approval Tool.
Apache License 2.0
0 stars 2 forks source link

Task/authentication #40

Closed kowalczyka closed 4 years ago

kowalczyka commented 4 years ago

Changes in this Pull Request:

Mandatory checks:

To be checked by the reviewer:

To be checked by the pull request owner:

Cross repository and core changes:

OSCM Build References:

Screenshot (if applicable):


This change is Reviewable

codecov[bot] commented 4 years ago

Codecov Report

Merging #40 into master will decrease coverage by 0.86%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #40      +/-   ##
============================================
- Coverage     41.71%   40.85%   -0.87%     
  Complexity      174      174              
============================================
  Files            34       37       +3     
  Lines          2100     2137      +37     
  Branches        176      178       +2     
============================================
- Hits            876      873       -3     
- Misses         1187     1227      +40     
  Partials         37       37              
Impacted Files Coverage Δ Complexity Δ
...g/oscm/app/approval/auth/AuthenticationFilter.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...src/main/java/org/oscm/app/approval/auth/User.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/java/org/oscm/app/approval/remote/BesClient.java 7.14% <0.00%> (-8.25%) 2.00 <0.00> (ø)
...a/org/oscm/app/approval/remote/WebServiceTask.java 35.71% <0.00%> (+10.71%) 2.00 <0.00> (ø)
...va/org/oscm/app/approval/servlet/LoginServlet.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ava/org/oscm/app/approval/servlet/ServiceBase.java 65.85% <0.00%> (-1.65%) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2590609...2f6e1fb. Read the comment docs.