servicecatalog / oscm-approval

OSCM Approval Tool.
Apache License 2.0
0 stars 2 forks source link

Get connection settings from approval controller. #41

Closed GoebelL closed 4 years ago

GoebelL commented 4 years ago

Changes in this Pull Request:

IMPORTANT: https://github.com/servicecatalog/oscm-app/pull/96 has to be merged first!

Mandatory checks:

To be checked by the reviewer:

Cross repository and core changes:

OSCM Build References:


This change is Reviewable

codecov[bot] commented 4 years ago

Codecov Report

Merging #41 into master will decrease coverage by 5.44%. The diff coverage is 2.70%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #41      +/-   ##
============================================
- Coverage     40.85%   35.40%   -5.45%     
+ Complexity      174      132      -42     
============================================
  Files            37       36       -1     
  Lines          2137     1980     -157     
  Branches        178      161      -17     
============================================
- Hits            873      701     -172     
- Misses         1227     1247      +20     
+ Partials         37       32       -5     
Impacted Files Coverage Δ Complexity Δ
...app/approval/activity/CTMGTriggerNotification.java 34.88% <ø> (ø) 6.00 <0.00> (ø)
...main/java/org/oscm/app/approval/database/Task.java 79.48% <ø> (ø) 4.00 <0.00> (ø)
...n/java/org/oscm/app/approval/remote/BesClient.java 6.45% <0.00%> (-0.70%) 2.00 <0.00> (ø)
...a/org/oscm/app/approval/remote/WebServiceTask.java 31.25% <0.00%> (-4.47%) 2.00 <0.00> (ø)
...a/org/oscm/app/approval/triggers/ApprovalTask.java 33.96% <0.00%> (+0.62%) 9.00 <0.00> (ø)
...n/java/org/oscm/app/dataaccess/AppDataService.java 5.88% <0.00%> (-73.65%) 2.00 <0.00> (-30.00)
...main/java/org/oscm/app/dataaccess/Credentials.java 64.28% <ø> (-23.95%) 6.00 <0.00> (-4.00)
...ava/org/oscm/app/approval/servlet/TaskServlet.java 66.29% <100.00%> (ø) 16.00 <0.00> (ø)
.../java/org/oscm/app/dataaccess/StringScrambler.java 0.00% <0.00%> (-78.95%) 0.00% <0.00%> (-3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f241d9a...08a3727. Read the comment docs.