Changes in this Pull Request:

Create tests for approval-json-api package
Remove unused class
Add tests for approval package

Mandatory checks:

[x] Branch is up to date (latest changes were fetched from the upstream branch before creating this PR)
[ ] Changes were tested manually
[ ] Java code changes are unit tested

To be checked by the reviewer:

[ ] Clean Java code and unit tested changes

To be checked by the pull request owner:

[ ] .MASTER/job/BES_MASTER_IT/
[ ] .MASTER/job/OSCM_WS_Tests_INTERNAL/
[ ] .MASTER/job/OSCM_WS_Tests_OIDC/
[ ] .MASTER/job/OSCM_Integration_Tests_INTERNAL/
[ ] .MASTER/job/OSCM_Integration_Tests_OIDC/

Cross repository and core changes:

[ ] Interdependent changes have been communicated to the team (if applicable)
[ ] This pull request includes high risk modifications or core changes (e.g API, datamodel, authentication...). Mandatory reviewers: @goebell or @kowalczyka.

OSCM Build References:

Build reference (e.g. tag on dockerhub)

Screenshot (if applicable):

This change is

Codecov Report

Merging #50 (f5de10b) into master (ba72b23) will increase coverage by 28.76%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master      #50       +/-   ##
===========================================
+ Coverage   52.13%   80.90%   +28.76%     
===========================================
  Files          48       40        -8     
  Lines        2225     1953      -272     
  Branches      220      183       -37     
===========================================
+ Hits         1160     1580      +420     
+ Misses       1007      303      -704     
- Partials       58       70       +12

Impacted Files	Coverage Δ
...a/org/oscm/app/approval/triggers/ApprovalTask.java	`88.67% <100.00%> (+53.46%)`	:arrow_up:
...oscm/app/approval/triggers/AutoApprovalThread.java	`86.66% <100.00%> (+86.66%)`	:arrow_up:
...in/java/org/oscm/app/approval/util/JsonResult.java	`73.07% <0.00%> (+5.76%)`	:arrow_up:
...approval/triggers/ApprovalNotificationService.java	`71.08% <0.00%> (+5.92%)`	:arrow_up:
...ava/org/oscm/app/approval/servlet/TaskServlet.java	`87.00% <0.00%> (+20.90%)`	:arrow_up:
...app/approval/activity/CTMGTriggerNotification.java	`90.69% <0.00%> (+55.81%)`	:arrow_up:
...a/org/oscm/app/approval/remote/WebServiceTask.java	`100.00% <0.00%> (+68.75%)`	:arrow_up:
...g/oscm/app/approval/auth/AuthenticationFilter.java	`75.00% <0.00%> (+75.00%)`	:arrow_up:
...a/org/oscm/app/approval/servlet/ServiceResult.java	`88.88% <0.00%> (+75.92%)`	:arrow_up:
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba72b23...f5de10b. Read the comment docs.

servicecatalog / oscm-approval

Task#45 improve test coverage #50

Codecov Report