servicecatalog / oscm-approval

OSCM Approval Tool.
Apache License 2.0
0 stars 2 forks source link

Authentication approver #52

Closed kowalczyka closed 4 years ago

kowalczyka commented 4 years ago

Changes in this Pull Request:

Mandatory checks:

To be checked by the reviewer:

To be checked by the pull request owner:

Cross repository and core changes:

OSCM Build References:

Screenshot (if applicable):


This change is Reviewable

codecov[bot] commented 4 years ago

Codecov Report

Merging #52 (16678c0) into master (5663c9a) will decrease coverage by 0.12%. The diff coverage is 52.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   52.07%   51.95%   -0.13%     
==========================================
  Files          47       47              
  Lines        2193     2200       +7     
  Branches      213      214       +1     
==========================================
+ Hits         1142     1143       +1     
- Misses        995     1002       +7     
+ Partials       56       55       -1     
Impacted Files Coverage Δ
...src/main/java/org/oscm/app/approval/auth/User.java 40.00% <0.00%> (+40.00%) :arrow_up:
...va/org/oscm/app/approval/servlet/LoginServlet.java 0.00% <0.00%> (ø)
...ava/org/oscm/app/approval/servlet/ServiceBase.java 68.29% <0.00%> (ø)
...a/org/oscm/app/approval/triggers/ApprovalTask.java 34.90% <0.00%> (ø)
...n/java/org/oscm/app/dataaccess/AppDataService.java 72.50% <20.00%> (-7.50%) :arrow_down:
...ava/org/oscm/app/approval/servlet/TaskServlet.java 66.10% <44.44%> (-0.20%) :arrow_down:
...main/java/org/oscm/app/approval/database/Task.java 76.54% <50.00%> (-4.23%) :arrow_down:
.../oscm/app/approval/database/DataAccessService.java 75.51% <86.95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5663c9a...16678c0. Read the comment docs.