servicecatalog / oscm-approval

OSCM Approval Tool.
Apache License 2.0
0 stars 2 forks source link

Show prices in email #53

Closed GoebelL closed 4 years ago

GoebelL commented 4 years ago

Changes in this Pull Request:

Mandatory checks:

To be checked by the reviewer:

To be checked by the pull request owner:

Cross repository and core changes:

OSCM Build References:

Screenshot (if applicable):


This change is Reviewable

codecov[bot] commented 4 years ago

Codecov Report

Merging #53 (bc7e18f) into master (e44d79a) will increase coverage by 18.15%. The diff coverage is 67.85%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #53       +/-   ##
=============================================
+ Coverage     34.56%   52.71%   +18.15%     
- Complexity      139      146        +7     
=============================================
  Files            38       48       +10     
  Lines          2083     2301      +218     
  Branches        171      212       +41     
=============================================
+ Hits            720     1213      +493     
+ Misses         1331     1029      -302     
- Partials         32       59       +27     
Impacted Files Coverage Δ Complexity Δ
...in/java/org/oscm/app/approval/json/PriceModel.java 0.00% <ø> (ø) 0.00 <0.00> (?)
.../main/java/org/oscm/app/approval/json/Service.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ain/java/org/oscm/app/approval/util/PriceText.java 63.15% <63.15%> (ø) 7.00 <7.00> (?)
...main/java/org/oscm/app/approval/database/Task.java 80.00% <100.00%> (+0.51%) 4.00 <0.00> (ø)
...a/org/oscm/app/approval/triggers/ApprovalTask.java 35.21% <100.00%> (+1.24%) 9.00 <0.00> (ø)
...main/java/org/oscm/app/approval/i18n/Messages.java 69.23% <0.00%> (-12.59%) 4.00% <0.00%> (ø%)
.../oscm/app/approval/database/DataAccessService.java 75.51% <0.00%> (-2.12%) 16.00% <0.00%> (ø%)
...a/org/oscm/app/approval/servlet/ServiceResult.java 12.96% <0.00%> (-0.50%) 4.00% <0.00%> (ø%)
...rc/main/java/org/oscm/app/connector/util/Util.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e44d79a...bc7e18f. Read the comment docs.