servicecatalog / oscm-dockerbuild

OSCM docker build files.
Apache License 2.0
3 stars 10 forks source link

Wrong install conditions of generated host certificates #310

Closed GoebelL closed 3 years ago

GoebelL commented 3 years ago

Summary Check and fix the condition of installing self-signed certificates

Details The oscm-deployer is used to setup OSCM. The container also generates a self-signed host certificate key pair and copies the files in the oscm-identity and oscm-proxy containers. By code reading I found that these steps are depending on the STARTUP parameter. It looks to me that this logic is in a wrong place here. Furthermore the code does not check for already existing SSL files. In case the user has already deployed an own SSL certificate, the oscm-deployer will overwrite the existing key pairs here. See here Besides of this, some code formatting is needed here.

Acceptance criteria

Additional context NA