Closed farmakiG closed 3 years ago
Merging #1248 (606f855) into master (6c2bbd9) will increase coverage by
0.00%
. The diff coverage is95.83%
.
@@ Coverage Diff @@
## master #1248 +/- ##
=========================================
Coverage 55.47% 55.47%
Complexity 14427 14427
=========================================
Files 1375 1375
Lines 80474 80473 -1
Branches 8598 8598
=========================================
Hits 44643 44643
+ Misses 33141 33140 -1
Partials 2690 2690
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...nicationservice/bean/CommunicationServiceBean.java | 67.67% <ø> (ø) |
32.00 <0.00> (ø) |
|
...oscm/identityservice/bean/IdentityServiceBean.java | 31.37% <ø> (ø) |
95.00 <0.00> (ø) |
|
.../oscm/identityservice/control/SendMailControl.java | 95.83% <95.83%> (+3.83%) |
10.00 <10.00> (ø) |
Changes in this Pull Request:
$enable-grid-classes
to falsemake-col-ready
mixin from .gridLayoutForCard.Explanation
In Bootstrap 5.0 Beta 3 (not in previous v4.3.1), Bootstrap creates the default grid classes as follows: in class _grid a row is created by using the
make-col-ready
mixin. So an entry is created:.row > *
withwidth: 100%
which breaks our service grid layout as it overwrites the widths of33,33 %
,50%
and so on of the columns at the different breakpoints.this default behavior is enabled by a boolean: $enable-grid-classes. It is not necessary to create these clases, as we create our own columns with the
.gridLayoutForCard
class andmake-col
mixins in _commonStyles.Mandatory checks:
To be checked by the reviewer:
To be checked by the pull request owner:
Cross repository and core changes:
OSCM Build References:
Screenshot (if applicable):
This change is