Task#1256 remove console warnings

[farmakiG]

Changes in this Pull Request:

• Removed console warnings about: 1) restorePaymentTab in subscriptionDetails page, 2) console warning "TypeError of null" for hexToHSL function.

Mandatory checks:

• [X] Branch is up to date (latest changes were fetched from the upstream branch before creating this PR)
• [X] Changes were tested manually
• [ ] Java code changes are unit tested
• [X] Webtests are successful

To be checked by the reviewer:

• [ ] Clean Java code and unit tested changes
• [ ] UI customizablity is preserved: No hard-coded styling and URL references in JSF views

To be checked by the pull request owner:

• [ ] .MASTER/job/BES_MASTER_IT/
• [ ] .MASTER/job/OSCM_WS_Tests_INTERNAL/
• [ ] .MASTER/job/OSCM_WS_Tests_OIDC/
• [ ] .MASTER/job/OSCM_Integration_Tests_INTERNAL/
• [ ] .MASTER/job/OSCM_Integration_Tests_OIDC/

Cross repository and core changes:

• [ ] Interdependent changes have been communicated to the team (if applicable)
• [ ] This pull request includes high risk modifications or core changes (e.g API, datamodel, authentication...). Mandatory reviewers: @goebell or @kowalczyka.

OSCM Build References:

• est6

Screenshot (if applicable): Screenshot Subscription Tabs Console warning:

Screenshot no warning:

Screenshot warning hexToHSL

Screenshot no warning:

---

This change is 

[codecov[bot]]

Codecov Report

Merging #1265 (4e5b288) into master (07eaaaf) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1265   +/-   ##
=========================================
  Coverage     55.47%   55.47%           
  Complexity    14427    14427           
=========================================
  Files          1375     1375           
  Lines         80473    80473           
  Branches       8598     8598           
=========================================
  Hits          44643    44643           
  Misses        33140    33140           
  Partials       2690     2690           

[farmakiG]

---

oscm-portal/WebContent/marketplace/account/subscriptionDetails.xhtml, line 74 at r1 (raw file):

Previously, GoebelL (Lorenz Goebel) wrote…

Are you sure restorePaymentTab is not needed? a) Did you test the payment tab in existing payed subscriptions ? b) I assume the method is still needed elsewhere as you didn't remove it completely. - If yes, did you check this part as well? - If no, please remove it completely.

You are right, this function is necessary, but only in the case that the #paymentTab is there.