servicecatalog / oscm

An Enterprise-ready Cloud Services Management Software.
https://openservicecatalogmanager.org
Apache License 2.0
38 stars 14 forks source link

Azure: wrong mail are resceived after deleting a Instance #153

Open elfriedegoetz opened 6 years ago

elfriedegoetz commented 6 years ago

[Build] docker 17.7 2018/10/05

[Steps to reproduce] create a azure instance -> instance is running goto subscription and terminate it

[Expected result] the instance is terminated, all resoures are deleted and a meaningful mail will be received

[Observed result] the instance is terminated, all resources are deleted, but the following mail is resceived:

Dear user,

The current operation on subscription 'AzureARM_Example1#1a9be903-ae00-433c-86fe-1274813d5198' for customer 'PLATFORM_OPERATOR' has been suspended (Instance: 'azure-192328a5-1c56-460f-abd9-beb5526d0f5b').

Reported problem: Azure returned the following error: Delete Resources failed:

To continue automatic processing, please click the following URL: https://estst1.intern.est.fujitsu.com:8881/oscm-app/notify?sid=azure-192328a5-1c56-460f-abd9-beb5526d0f5b&controllerid=ess.azureARM&_resume=yes

If the problem cannot be solved and the processing cannot be continued, please terminate the subscription and create a new one.

elfriedegoetz commented 6 years ago

A wrong mail is still being sent Dear user,

The subscription 'AzureARM_Example#939d12bc-74bc-4eda-a844-973d61b0da79' for customer 'PLATFORM_OPERATOR' has been terminated but the instance 'azure-9b525b37-a6e3-46d0-b5b1-3b3922a828e0' could not be deleted.

No row with the given identifier exists: [org.oscm.app.domain.InstanceParameter#1019]

With best regards.

This email has been generated automatically. Please do not reply to this email.

elfriedegoetz commented 6 years ago

I tested with build from 23.10.2018

ghost commented 6 years ago

This looks quite different than the old one. Old one was directly related to Azure controller and the way instance was deleted. An error was thrown by the Azure portal API. In this case, it looks like internal oscm error.

I am not sure why it is thrown, so I will try to investigate that.

ghost commented 6 years ago

Closed by #168

elfriedegoetz commented 6 years ago

Dear user,

The subscription 'AzureARM_Example#360d219c-563e-4153-81e0-c616559c8f05' for customer 'PLATFORM_OPERATOR' has been terminated but the instance 'azure-770ca01c-fc63-4e6e-ac97-05bea2ad9a66' could not be deleted.

java.lang.NullPointerException

With best regards.

This email has been generated automatically. Please do not reply to this email.