search

servicemesh-es / servicemesh.es

Source for http://servicemesh.es
Other
41 stars 30 forks source link

update Istio per-route metrics #9

Closed oaktowner closed 4 years ago

oaktowner commented 5 years ago

One minor correction: Istio does collect per-route metrics.

Thanks!

HPrinz commented 5 years ago

Great, I didn't know that! Do you have link to the docs that shows that?

oaktowner commented 5 years ago

Ack! Our docs are incomplete!

Listed here https://raw.githubusercontent.com/istio/istio/release-1.4/install/kubernetes/helm/istio/charts/mixer/templates/config.yaml (see method: request.method )

But I'll submit a PR over there to get it here as well:

BTW, I'll add one more commit bumping up our version number.

oaktowner commented 5 years ago

Please hold off on this for now -- this metric is turned off be default right now and I'm researching why. Thanks for your patience!

HPrinz commented 5 years ago

Yes, sure! Take your time