servicemeshinterface / smi-spec

Service Mesh Interface
https://smi-spec.io
Apache License 2.0
1.05k stars 125 forks source link

No warning if incorrect yaml is applied for Traffic Split #235

Closed mudit-01 closed 2 years ago

mudit-01 commented 3 years ago

Describe the proposal

For traffic split, if weights are distributed in an improper way like all weights don't sum up to 100 or all weights sum > 100. We don't get an error message that yaml is incorrect. Scope

Possible use cases

apply the yaml with irregular weights like 1000, -200 etc. the yaml will be applied successfully without error. This should throw an error message.

jbyers19 commented 3 years ago

Hi, @mudit-01. This was discussed on the SMI community call today and the consensus was that this proposal is outside the scope of this spec. Validation beyond that enforced by the OpenAPI schema in the TrafficSplit CRD is left to those implmenting this spec.

if weights are distributed in an improper way like all weights don't sum up to 100 or all weights sum > 100

The weights are not percentages, so there should be no issue if the weights do not add up to 100.