@types packages should go in devDependencies

serviejs / popsicle

Simple HTTP requests for node and the browser

MIT License

246 stars 19 forks source link

@types packages should go in devDependencies #128

Closed evert closed 5 years ago

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 625

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.217%

Totals
Change from base Build 624:	0.0%
Covered Lines:	283
Relevant Lines:	357

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 625

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.217%

Totals
Change from base Build 624:	0.0%
Covered Lines:	283
Relevant Lines:	357

💛 - Coveralls

blakeembrey commented 5 years ago

No, this will break consumers of node since it's using the types defined in @types: https://github.com/serviejs/popsicle/blob/7a6865b6beef3a313397b86edcfdb78310a5b9a7/src/node.ts#L11

evert commented 5 years ago

Ah interesting. That's kind of a shitty experience, but I can see that it's the only way. I suppose in an ideal world we would have a way to mark devDependencies to be installed recursively.