search

serviejs / popsicle

Simple HTTP requests for node and the browser
MIT License
246 stars 19 forks source link

Error: Cannot find module 'popsicle-cookie-jar' #157

Closed lili2311 closed 9 months ago

lili2311 commented 9 months ago

@amplitude/ampli no longer installing correctly since the removal of 'popsicle-cookie-jar'

 ›   Update with npm:
 ›   npm install [-g] @amplitude/ampli
 ›   ────────────────────────────────────────────────
    Error: Cannot find module 'popsicle-cookie-jar'
    Require stack:
    - /Users/lili/.npm/_npx/4d0ace3a9fc0b796/node_modules/popsicle/dist/node.js
    - /Users/lili/.npm/_npx/4d0ace3a9fc0b796/node_modules/popsicle/dist/index.js
    - /Users/lili/.npm/_npx/4d0ace3a9fc0b796/node_modules/client-oauth2/src/request/index.js
    - /Users/lili/.npm/_npx/4d0ace3a9fc0b796/node_modules/client-oauth2/src/client-oauth2.js
    - /Users/lili/.npm/_npx/4d0ace3a9fc0b796/node_modules/@amplitude/ampli/lib/auth/index.js
    - /Users/lili/.npm/_npx/4d0ace3a9fc0b796/node_modules/@amplitude/ampli/lib/actions/base.js
    - /Users/lili/.npm/_npx/4d0ace3a9fc0b796/node_modules/@amplitude/ampli/lib/base.js
    - /Users/lili/.npm/_npx/4d0ace3a9fc0b796/node_modules/@amplitude/ampli/lib/commands/status.js
    - /Users/lili/.npm/_npx/4d0ace3a9fc0b796/node_modules/@oclif/config/lib/plugin.js
    - /Users/lili/.npm/_npx/4d0ace3a9fc0b796/node_modules/@oclif/config/lib/config.js
    - /Users/lili/.npm/_npx/4d0ace3a9fc0b796/node_modules/@oclif/config/lib/index.js
    - /Users/lili/.npm/_npx/4d0ace3a9fc0b796/node_modules/@oclif/command/lib/command.js
    - /Users/lili/.npm/_npx/4d0ace3a9fc0b796/node_modules/@oclif/command/lib/index.js
    - /Users/lili/.npm/_npx/4d0ace3a9fc0b796/node_modules/@amplitude/ampli/bin/run
    Code: MODULE_NOT_FOUND

https://github.com/serviejs/popsicle/commit/e2fa3086f87e276d797da87a1869454054064e01#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L99 this removes a dependency that is required

blakeembrey commented 9 months ago

Shoot, I'm seriously sorry about that. I just published a new release with the fix: https://github.com/serviejs/popsicle/releases/tag/v12.1.2

Sadly that was a messy change due to old versions no longer working. I should have split it into a couple of changes so popsicle-cookie-jar didn't accidentally land in dev dependencies. Thanks for the report!

Tirke commented 9 months ago

Thanks for the reactivity 😄