search

serviejs / popsicle

Simple HTTP requests for node and the browser
MIT License
246 stars 19 forks source link

More details on Typescript installation #80

Closed v1v2r0b8 closed 7 years ago

v1v2r0b8 commented 7 years ago

Following issue #57 . I have spent a couple of hours on it too.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 95.431% when pulling 67e58fc17aa11b0bdf5c6c8b840ab948274aa309 on leitasat:leitasat-typescript-installation-details into 3841002aa0c94c0c1239c50493c98a0364a8ac21 on blakeembrey:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 95.431% when pulling 67e58fc17aa11b0bdf5c6c8b840ab948274aa309 on leitasat:leitasat-typescript-installation-details into 3841002aa0c94c0c1239c50493c98a0364a8ac21 on blakeembrey:master.

blakeembrey commented 7 years ago

The installation from typings already says this and has the relevant directions in its README. Also, those directions are subjective. For one, I use env~node from https://github.com/types/env-node and I don't use the files section in typings.json (it should automatically be picked up using TypeScript, unless you're using files or includes then you do need to add it).

v1v2r0b8 commented 7 years ago

@blakeembrey I've just copied instructions from the issue's discussion, to be honest. May be it makes sense then to include the link to proper instruction of typings' installation? Because I did just npm install typings and thought that I am good to go.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 95.28% when pulling 2b3d59c6d3c1b8f7c97ead0ae771a4ecfe6032aa on leitasat:leitasat-typescript-installation-details into 3841002aa0c94c0c1239c50493c98a0364a8ac21 on blakeembrey:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 95.28% when pulling 2b3d59c6d3c1b8f7c97ead0ae771a4ecfe6032aa on leitasat:leitasat-typescript-installation-details into 3841002aa0c94c0c1239c50493c98a0364a8ac21 on blakeembrey:master.