search

servinglynk / hslynk-open-source-docs

Contains wiki documentation, and issue tracker for the HSLynk Open Human Services Data Exchange Platform project. Code is in a different repo: https://github.com/servinglynk/hslynk-open-source . API docs are at https://docs.hslynk.com . General website is at:
http://www.hslynk.com/
Mozilla Public License 2.0
9 stars 3 forks source link

unit tests for APR #733

Open eric-jahn opened 5 years ago

eric-jahn commented 5 years ago

We should have APR unit tests that run on build, which compare:

1) ...to the HMIS APR sample CSV test kit report from HUD. Using the HUD HMIS sample test kit client data CSV, does the HSLynk APR return the same aggregate results as the HUD HMIS APR sample test kit report?

2) ...specific subtotals to grand totals. So these would be a series of report internal checks, like "with income + without income = total")?

eric-jahn commented 5 years ago

I think #1 would just be a matter of comparing each cell, and if one of them does not match, list it and return "test fails".

For #2, we should first come up with a minimal list of validation checks.

Then we should write up the unit tests in psuedocode/JUnit/JMeter/whichever you guys agree on, and add to the build process, making HSLynk builds fail if this doesn't pass.

eric-jahn commented 5 years ago

@kiadso Do you think you could work on #2? I think we could also use this sort of assistance for the LSA report validations as well, which you've worked on before.

kiadso commented 5 years ago

Sure- just in a text file for now? Or markdown?

eric-jahn commented 5 years ago

@kiadso Whichever you think is more useful. Markdown would be good I think, because we can make a nice wiki page out of it, and link it to the issue.

kiadso commented 5 years ago

I agree- is there already an existing list for the previous APR?

eric-jahn commented 5 years ago

@logicsandeep: Do you have a list of validations for the APR, or do we not have any tests yet? I guess we could start with the Sage validations, if HUD posted them.

kiadso commented 5 years ago

The HMIS Glossary has a lot of validations in it too- I can just use that and the APR specs for now.

eric-jahn commented 5 years ago

see https://github.com/servinglynk/hslynk-open-source-docs/wiki/APR_Unit_Testing_FY2020