search

servinglynk / hslynk-open-source-docs

Contains wiki documentation, and issue tracker for the HSLynk Open Human Services Data Exchange Platform project. Code is in a different repo: https://github.com/servinglynk/hslynk-open-source . API docs are at https://docs.hslynk.com . General website is at:
http://www.hslynk.com/
Mozilla Public License 2.0
9 stars 3 forks source link

Child links are not populated in GET /enrollments/{enrollmentId} API #893

Open logicsandeep opened 4 years ago

logicsandeep commented 4 years ago

For example: v2020/clients/76f57a18-abd4-4848-925e-fe88feea1b00/enrollments/6b8b3900-3b07-4875-9a2a-400f0f141f22?includeChildLinks=true

suryayadavalli commented 4 years ago

Looked into this issue in detail. The child links population logic is dependent on datacollectionstage for the childs.

current_living_situation do not have datacollectionstage, hence it is not considered for grouping while computing the response.

Here is the requirment for child links https://github.com/servinglynk/hslynk-open-source-docs/issues/588

Question is : why datacollectionstage column is not present for current_living_situation entity (I see its not present for other entities as well). Just wondering is it by design or a bug?

Assigning back to @logicsandeep to look into this.

logicsandeep commented 4 years ago
Screen Shot 2020-11-01 at 6 29 26 PM

The child link for currentLivingSituations should exist with "unspecified_stage" just like dataOfEngagements in the screenshot attached. dateOfEngagements also does not contain datacollectionstage.

Check out this URL: /v2020/clients/1abbdfa8-bc83-4dc0-a7a1-48d0229ec5e3/enrollments/13cd16bc-8da3-4426-8511-9771b630ca41?includeChildLinks=true

Please let me know if you need further information.

suryayadavalli commented 4 years ago

@logicsandeep : Thanks for the clarification. Yes, You are correct. It's an API issue. I will work on the fix.

suryayadavalli commented 4 years ago

@logicsandeep : Issue with CurrentLivingSituation is resolved now. However, I see that this issue exists for three more entities (for the same reason) and I am fixing them as well. You should be able to verify this specific fix. Thanks !

logicsandeep commented 4 years ago

Excellent Thanks @suryayadavalli