servisys / ispconfig_setup

ISPConfig autoinstaller and setup
GNU General Public License v3.0
507 stars 257 forks source link

Added support for Raspbian, updated packages, output and added Travis CI. #259

Closed tdulcet closed 5 years ago

tdulcet commented 5 years ago
schliflo commented 5 years ago

This is one hell of a contribution. Thx for making @servisys life a bit easier and this awesome tool a bit better <3

servisys commented 5 years ago

Thank you, i'll take a look for merge soon :)

servisys commented 5 years ago

Why replaced all apt-get install (or similar) with apt_install (wich is not a command)?

tdulcet commented 5 years ago

The function is defined here: https://github.com/tdulcet/ispconfig_setup/blob/master/functions/check_linux.sh#L28. There are similar functions below it for yum and the other package managers.

It hides the output of apt-get unless it returns a nonzero exit code (for debugging), instead of redirecting all the output to /dev/null. In other words, it only shows the output if there is an error.

servisys commented 5 years ago

Oh wtf, i was serching for the function, now i've seen it! Thank you, very great work, was really needed :)

schliflo commented 5 years ago

Hey @servisys I guess you still need to setup Travis CI, right? Currently there are no tests running as the project does not exist: https://travis-ci.org/servisys/ispconfig_setup

tdulcet commented 5 years ago

Yeah, you need to sign in at travis-ci.org and enable it for this repository.

Also, it seems that these issues: #67, #68, #69, #70 and #176 were automatically closed because I mentioned them in the pull request, but I did not actually resolve them...

tdulcet commented 5 years ago

@servisys I am not sure why you made this change: https://github.com/servisys/ispconfig_setup/commit/f0e808aa40de3ab9569efc642357bc3214b067d1#diff-3fbb47e318cd8802bd325e7da9aaabe8

The HowtoForge The Perfect Server tutorials state the hostname file should just contain the subdomain part of the FQDN: https://www.howtoforge.com/tutorial/perfect-server-debian-9-stretch-apache-bind-dovecot-ispconfig-3-1/#-configure-thenbsphostname

schliflo commented 5 years ago

@servisys you still need to setup travis CI to get the tests running. Let me know if you need help.

servisys commented 5 years ago

Sorry... but what are you talking about?

schliflo commented 5 years ago

@tdulcet integrated some very basic tests, which are configured in this file: https://github.com/servisys/ispconfig_setup/blob/master/.travis.yml They should be running here: https://travis-ci.org/servisys/ispconfig_setup but the project has to be initialised once by the owner (you) - which you haven't done so far. Travis CI is free for open source projects and a good way to automatically spot bugs.

servisys commented 5 years ago

Done :D

schliflo commented 5 years ago

Idk what you did, but the build badge on top of the readme still says unknown: screenshot 2018-10-04 at 17 14 02 And https://travis-ci.org/servisys/ispconfig_setup still is not found, so i guess that probably went wrong :/

tdulcet commented 5 years ago

You may have to wait until the first commit after it was enabled for the link to work.

schliflo commented 5 years ago

@tdulcet you're correct. Seems to be working now: https://travis-ci.org/servisys/ispconfig_setup/builds/437483820 :) Nice!