search

servo-php / fluidxml

FluidXML, the PHP library for manipulating XML with a concise and fluent API.
BSD 2-Clause "Simplified" License
458 stars 45 forks source link

PHP5 support #2

Closed garex closed 8 years ago

garex commented 8 years ago

Not support 5.x :((

It was a showstopper.

daniele-orlando commented 8 years ago

Porting to PHP 5 is very easy. The only issue back porting is finding a satisfying solution for the namespace() method which is an invalid method name in PHP 5.

I'm evaluating a solution.

daniele-orlando commented 8 years ago

PHP 5.6 is the new minimum version. Have fun! ;)

garex commented 8 years ago

Nice. But where is .travis.yml with tests running on both php5.6 and 7.0? You know — we are watchin for you! birds

daniele-orlando commented 8 years ago

Checkout the last commit! ;)

Thanks for the feedback. <3

daniele-orlando commented 8 years ago

Closed by c8a5c9252325b1b51c10bf0af2f384a9aa556193.

garex commented 8 years ago

))