Support PHP 8.1+ - Githubissues

servo-php / fluidxml

FluidXML, the PHP library for manipulating XML with a concise and fluent API.

BSD 2-Clause "Simplified" License

458 stars 45 forks source link

Support PHP 8.1+ #63

Closed nicekiwi closed 11 months ago

nicekiwi commented 11 months ago

Drop support for unsupported PHP versions.
Fix deprecations in DOMElement.
Add return types where known.
Use Rector for the majority of PHP updates.
Bump version to 1.3.0.

Relatively blind update, to bring up to date.

nicekiwi commented 11 months ago

Also resolves #62

daniele-orlando commented 11 months ago

Hi Ezra, thank you very much for your awesome contribution. It seams almost perfect to me.

Due to the breaking nature of the changes (we drop support for PHP versions < 8), accordingly with the semantic versioning, we must release a major version.

Please update the merge request to mark fluidxml as version 2.0.0.

Given that, we should be ready to go.

nicekiwi commented 11 months ago

@daniele-orlando done 🚀 I've updated the CI/test configs to use the new PHP versions and tested against our production App too.

Though Scrutinizer still seems to have an issue authenticating between Github and composer.