Use 1<<30 - 1 for max/min values to avoid overflow

servo / app_units

https://crates.io/crates/app_units

3 stars 17 forks source link

Closed Manishearth closed 7 years ago

Manishearth commented 7 years ago

(1<<30) + (1<<30) will overflow an i32, but no other combination of valid Au values will.

Manishearth commented 7 years ago

@bors-servo r=emilio

bors-servo commented 7 years ago

:pushpin: Commit 3abe38d has been approved by emilio

bors-servo commented 7 years ago

:hourglass: Testing commit 3abe38d2e49eabe37e2120ba43fe46e094c7a3cd with merge 87dcfd570331c254914ea4355c8341dc79fc0667...

bors-servo commented 7 years ago

:sunny: Test successful - status-travis Approved by: emilio Pushing 87dcfd570331c254914ea4355c8341dc79fc0667 to master...