servo / app_units

https://crates.io/crates/app_units
3 stars 17 forks source link

Refactor and update app_units for 2021 #47

Closed Florian-Schoenherr closed 2 years ago

Florian-Schoenherr commented 2 years ago

Don't know how I got here but it is what it is. I compared serde-derive Serialize to the current impl with time cargo build, doesn't make much of a difference, but might be bad for some reason? Serialize doesn't do anything special so I think deriving it is better.

What should I bump the version to, if approved?

jdm commented 2 years ago

@bors-servo r+ Thanks!

bors-servo commented 2 years ago

:pushpin: Commit d60d142 has been approved by jdm

bors-servo commented 2 years ago

:hourglass: Testing commit d60d142673b89864936fa54f82930548d15cd554 with merge 8043cd5e858371b541f572fa75badf8036b7ba79...

bors-servo commented 2 years ago

:sunny: Test successful - checks-github Approved by: jdm Pushing 8043cd5e858371b541f572fa75badf8036b7ba79 to master...