search

servo / cocoa-rs

DEPRECATED - Cocoa/Objective-C bindings for the Rust programming language
https://github.com/servo/core-foundation-rs/
Other
286 stars 72 forks source link

Add NSDictionary + tests, define NSComparator and NSComparisonResult #137

Closed burtonageo closed 8 years ago

burtonageo commented 8 years ago

This change is Reviewable

metajack commented 8 years ago

r? @pcwalton

pcwalton commented 8 years ago

@bors-servo: r+

bors-servo commented 8 years ago

:pushpin: Commit 0b07a79 has been approved by pcwalton

bors-servo commented 8 years ago

:hourglass: Testing commit 0b07a79 with merge 8dbd53c...

bors-servo commented 8 years ago

:broken_heart: Test failed - travis

jdm commented 8 years ago 
unning 8 tests

test foundation::nsdictionary::test_get ... ok

test foundation::nsdictionary::test_iter ... FAILED

test foundation::nsfastenumeration::test_iter ... ok

test foundation::nsfastenumeration::test_mutation ... ok

test foundation::nsstring::test_append_by_appending_string ... ok

test foundation::nsstring::test_length ... ok

test foundation::nsstring::test_utf8 ... ok

test foundation::nsstring::test_string ... ok

failures:

---- foundation::nsdictionary::test_iter stdout ----

    thread 'foundation::nsdictionary::test_iter' panicked at 'assertion failed: k0.isEqualToString(k1)', tests/foundation.rs:168

note: Run with `RUST_BACKTRACE=1` for a backtrace.

failures:

    foundation::nsdictionary::test_iter

test result: FAILED. 7 passed; 1 failed; 0 ignored; 0 measured
burtonageo commented 8 years ago

For some reason this passes locally to me :-/

jdm commented 8 years ago

@bors-servo: retry

bors-servo commented 8 years ago

:hourglass: Testing commit 0b07a79 with merge a21ac59...

bors-servo commented 8 years ago

:sunny: Test successful - status-travis