Allow core-graphics 0.8 and bump version - Githubissues

servo / cocoa-rs

DEPRECATED - Cocoa/Objective-C bindings for the Rust programming language

https://github.com/servo/core-foundation-rs/

Other

286 stars 72 forks source link

Allow core-graphics 0.8 and bump version #162

Closed Eijebong closed 7 years ago

Eijebong commented 7 years ago

This change is

nox commented 7 years ago

This may break things downstream for people using core-graphics 0.7. Ranges caused issues in the past already.

Eijebong commented 7 years ago

Ok, then let's not do ranges :p

killercup commented 7 years ago

@Eijebong asked me to test this, and it compiles fine on macOS 10.12.5 with rustc 1.18 (stable).

emilio commented 7 years ago

This still needs an update @Eijebong.

Eijebong commented 7 years ago

Woups, pushed on the wrong branch ^^

emilio commented 7 years ago

@bors-servo r+

bors-servo commented 7 years ago

:pushpin: Commit 9e3557f has been approved by emilio

bors-servo commented 7 years ago

:hourglass: Testing commit 9e3557f416aa1ae52efd85438a7432dd015c7ec5 with merge 4e026ba4becd33486107290ca8a4dcfc823ec018...

emilio commented 7 years ago

Thanks @killercup for testing again!

bors-servo commented 7 years ago

:broken_heart: Test failed - status-travis

glennw commented 7 years ago

@bors-servo retry

travis?

bors-servo commented 7 years ago

:hourglass: Testing commit 9e3557f416aa1ae52efd85438a7432dd015c7ec5 with merge b1717bb76b0f007ce061b0b4c49d7336b5c075c9...

glennw commented 7 years ago

@bors-servo r=emilio

bors-servo commented 7 years ago

:pushpin: Commit 4375963 has been approved by emilio

bors-servo commented 7 years ago

:hourglass: Testing commit 437596359a32acb3d38dba62f4d72b8c1f6dc14d with merge 58162a165f29b5fce0e1759841d592f32e543557...

bors-servo commented 7 years ago

:sunny: Test successful - status-travis Approved by: emilio Pushing 58162a165f29b5fce0e1759841d592f32e543557 to master...