servo / core-foundation-rs

Rust bindings to Core Foundation and other low level libraries on Mac OS X and iOS
Other
991 stars 216 forks source link

Drop #[no_mangle] from cg_event_tap_callback_internal #612

Closed jrmuizel closed 1 year ago

jrmuizel commented 1 year ago

This allows multiple versions of core-graphics to be linked into the same binaries without getting "duplicate symbol: cg_event_tap_callback_internal"

jrmuizel commented 1 year ago

Previously the only major version that included this symbol was 0.22 now that 0.23 also has it we're much more likely to get in trouble.

mstange commented 1 year ago

@bors-servo r+

bors-servo commented 1 year ago

:pushpin: Commit f3cf0f1 has been approved by mstange

bors-servo commented 1 year ago

:hourglass: Testing commit f3cf0f1d386563f939a6b43e04ce9b0639a89971 with merge 15d824ad35ea93dd6cd8c55fa253abd8ded0a01d...

bors-servo commented 1 year ago

:sunny: Test successful - checks-github Approved by: mstange Pushing 15d824ad35ea93dd6cd8c55fa253abd8ded0a01d to master...