search

servo / core-foundation-rs

Rust bindings to Core Foundation and other low level libraries on Mac OS X and iOS
Other
991 stars 216 forks source link

Update to 2018 edition #642

Closed waywardmonkeys closed 10 months ago

waywardmonkeys commented 11 months ago

This doesn't get away from extern crate yet.

Is this set of changes welcome?

jdm commented 11 months ago

I'm in favour.

waywardmonkeys commented 11 months ago

@jdm Okay, marked as ready for review and rebased.

Follow up PRs can do things like update to 2021 edition (MSRV is 1.56, so that's probably fine) and remove all of the extern crate stuff.

waywardmonkeys commented 11 months ago

@jdm Any further thoughts on this?

waywardmonkeys commented 11 months ago

@jrmuizel Any thoughts on this?

jrmuizel commented 11 months ago

I quickly skimmed it. Can you add a summary of what was changed to the commit message?

waywardmonkeys commented 10 months ago

@jrmuizel Done.