search

servo / core-foundation-rs

Rust bindings to Core Foundation and other low level libraries on Mac OS X and iOS
Other
987 stars 216 forks source link

Add visionOS and watchOS to linking to CoreFoundation framework #679

Closed simlay closed 3 months ago

simlay commented 3 months ago

When using a few patches for various tls and security framework features to build for visionOS and watchOS (among other apple targets), I ran into a linking error.

In https://github.com/rust-lang/rust/pull/125225, linking to Foundation was removed which I think caused some link errors for visionOS and watchOS on rust nightly-2024-05-22.

These are the fixes to those errors.

simlay commented 3 months ago

my apologies that I didn't consider that it might affect badly configured link invocations like this

No worries. It's part of nightly and using tier 3 targets. We'll eventually patch all the links.

simlay commented 3 months ago

@jdm CI failed on rustfmt so I cargo fmt'd, squashed commit and pushed. I think you have to push the "auto merge" button again as I've made a change.

simlay commented 3 months ago

Uh, the auto merge merged the unfmt'd commit? Now CI is red. It ignored my push to fix rustfmt and claims the PR is merged when there's obviously an unmerged commit. I expect better of this free software (github).