servo / core-foundation-rs

Rust bindings to Core Foundation and other low level libraries on Mac OS X and iOS
Other
987 stars 216 forks source link

Bump version of core-foundation-sys to 0.8.7 #683

Closed wusyong closed 1 month ago

wusyong commented 3 months ago

I opened a topic in Zulip regarding some crate maintenance under Servo org. @jdm gave some advice on how to update crate version. I guess I can start with sys crate and open other PRs one by one. Does this look good to other maintainers?

jdm commented 3 months ago

Which commit in https://github.com/servo/core-foundation-rs/commits/main/core-foundation-sys since the 0.8.6 version update contains breaking changes?

wusyong commented 3 months ago

I see #642 as a breaking change since I remember cases of build failure when upgrading from 2015 to 2018. But in general, I think it will be up to the author to decide. If everyone prefers, I can change it to patch bump instead.

jdm commented 3 months ago

Edition changes should not affect the public API. I believe a patch version update would be correct here.