servo / core-foundation-rs

Rust bindings to Core Foundation and other low level libraries on Mac OS X and iOS
Other
987 stars 216 forks source link

Incorrect function parameters for `CFCalendarGetIdentifier` #685

Open ashu26jha opened 2 months ago

ashu26jha commented 2 months ago

According to Apple documentation CFCalendarGetIdentifier must take a CFCalendarRef as an input parameter and return the calendar's identifier.

But according core-foundation-sys, the docs states:

pub unsafe extern "C" fn CFCalendarGetIdentifier(
    identifier: CFCalendarIdentifier
) -> CFCalendarIdentifier

Please have a look, I checked in the repo

Also this mismatch can also be found for: CFCalendarCopyLocale which should should take CFCalendarCopyLocale instead of CFCalendarIdentifier