search

servo / euclid

Geometry primitives (basic linear algebra) for Rust
Other
460 stars 102 forks source link

Add support for matrix decomposition #335

Open Manishearth opened 5 years ago

Manishearth commented 5 years ago

Servo has code for this already, but I think it's written for column vector matrices since that's what css-transforms uses

I need this for XR stuff anyway and both Gecko and Chromium have 3d and 2d matrix decompositions in their libraries. It would be nice if Servo could use an implementation from euclid for both the CSS stuff as well as XR stuff.

nical commented 5 years ago

Sounds good to me! Euclid already has a few equivalents for some of the types in this file, and there is the question of whether we want to sort out the column/vector story before or implement this with row vectors instead, but other than that I'm game for moving this implementation here.

Manishearth commented 5 years ago

I would like to sort out the column/row story first but this also may require sorting it out on the gecko side as well :/

nical commented 5 years ago

Yeah, the gecko side isn't necessarily more work than servo. Needs to be investigated though.

Manishearth commented 5 years ago

Do you have the bandwidth to start looking at the Gecko side? I'd have made the Euclid changes already if it was just the servo side; this issue keeps cropping up as I implement web specs.

On Tue, Apr 9, 2019, 7:44 AM Nicolas Silva notifications@github.com wrote:

Yeah, the gecko side isn't necessarily more work than servo. Needs to be investigated though.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/servo/euclid/issues/335#issuecomment-481282604, or mute the thread https://github.com/notifications/unsubscribe-auth/ABivSOt1-BuDa2Lhi9JGtLqRgfbXOMtAks5vfKdmgaJpZM4cjJtu .

nical commented 5 years ago

I currently don't have the bandwidth to delve into the gecko side.

Manishearth commented 5 years ago

Good to know, thanks.

On Fri, Apr 12, 2019, 9:32 AM Nicolas Silva notifications@github.com wrote:

I currently don't have the bandwidth to delve into the gecko side.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/servo/euclid/issues/335#issuecomment-482639707, or mute the thread https://github.com/notifications/unsubscribe-auth/ABivSKzxgfKraIFZGaDfSAE7SuaivcTiks5vgLUqgaJpZM4cjJtu .