A few non-breaking changes

nical commented 5 years ago

Add pre/post_transform, deprecate pre/post_mul. This name is less ambiguous: the meaning of pre and post here is really about the semantics of the tranformation and not about the underlying matrix the latter being currently in a confusing step for a number of people.
Add a default module with type aliases for the default unit. The goal is to rename all TypedFoo types into Foo next time we commit to a breaking change and use default::Foo for the aliases with unknown units.
Remove unstable must_use annotations. They add noise to the code and aren't very useful since they only work with the nightly compiler and the unstable feature.

The first two changes will let us transition some of the names at our leasure rather than having to do it all next time we do the Big Breaking Change.

This change is

nical commented 5 years ago

r? @kvark

Note that I put default::Vector4D in lieu of default::HomogeneousVector because I prefer it that way but that's up for debate. The rest should be fairly uncontroversial I think.

nical commented 5 years ago

src/lib.rs, line 143 at r1 (raw file):

Previously, kvark (Dzmitry Malyshau) wrote…

if we end up with just `Point2D`, what would be the use for `default` module?

These default type parameters have never ended up being useful. I'm not even sure in what situations the compiler decides to make usre of that information.

nical commented 5 years ago

@bors-servo r=kvark

bors-servo commented 5 years ago

:pushpin: Commit 65c0e85 has been approved by kvark

bors-servo commented 5 years ago

:hourglass: Testing commit 65c0e85e57c2b527df2baac728cb255bcc3ed549 with merge b37eb9de57dfaf07661387fd71ac5abcd17200d0...

bors-servo commented 5 years ago

:sunny: Test successful - checks-travis Approved by: kvark Pushing b37eb9de57dfaf07661387fd71ac5abcd17200d0 to master...

servo / euclid

A few non-breaking changes #349