search

servo / euclid

Geometry primitives (basic linear algebra) for Rust
Other
458 stars 102 forks source link

angle: split angle.rs from rotation.rs #381

Closed pbor closed 4 years ago

pbor commented 4 years ago

Feel free to throw this away, but I was reading through Euclid's code and I would have found it more clear to have Angle in its own module, as we do for Rect etc.

(I want to compare it with https://gitlab.gnome.org/GNOME/librsvg/blob/master/rsvg_internals/src/angle.rs )

nical commented 4 years ago

I don't feel strongly either way.

@bors-servo r+

bors-servo commented 4 years ago

:pushpin: Commit 1786197 has been approved by nical

bors-servo commented 4 years ago

:hourglass: Testing commit 178619706667d9b9a6f5d879ab38bb7c1b09938a with merge 3e18046c9dc08a0055be05a158334f854485eac7...

bors-servo commented 4 years ago

:sunny: Test successful - checks-travis Approved by: nical Pushing 3e18046c9dc08a0055be05a158334f854485eac7 to master...