Fix Box2D/Box3D::from_points.

servo / euclid

Geometry primitives (basic linear algebra) for Rust

Other

458 stars 102 forks source link

Fix Box2D/Box3D::from_points. #392

Closed nical closed 4 years ago

nical commented 4 years ago

The behavior of returning Box2D::zero() when a single point is passed was unintuitive and inconsistent with the behavior previoulsy established in Rect::from_points (to return an empty rect at the position of the single point).

Fixes #390.

nical commented 4 years ago

r? @kvark

nical commented 4 years ago

@bors-servo r=kvark

bors-servo commented 4 years ago

:pushpin: Commit 5c79954 has been approved by kvark

bors-servo commented 4 years ago

:hourglass: Testing commit 5c799541cb96ebf5a38155a1c242dcc0a560fa06 with merge db6446269045275bb3cf73979a3f3dcf7f0cd25e...

bors-servo commented 4 years ago

:sunny: Test successful - checks-travis Approved by: kvark Pushing db6446269045275bb3cf73979a3f3dcf7f0cd25e to master...