search

servo / euclid

Geometry primitives (basic linear algebra) for Rust
Other
458 stars 102 forks source link

Some refactoring and documentation for scale.rs #410

Closed Mingun closed 4 years ago

Mingun commented 4 years ago

Actually, this is part of a changes whose ultimate goal is to improve the ergonomics of the library. There are too many of them, so some of them I decided to provide in separate PRs. That is first.

Commit 19ddcfe24564ebc7b0403cbfd0c9899021082e76 introduce soft breaking change. I call it soft because very unlikely, that users faced with them, because that only replaces borrow with move for self parameter -- but if you don't use UFCS, you even will not notice that. And because before that change Copy type was required, after that change that method always called with Copy types, so no errors, related to borrow checker, can occur if you simply upgraded to new version of the library. Benefit in that after this change you can control if you wish to make a copy, and that methods can now work with non-Copy types.

bors-servo commented 4 years ago

:umbrella: The latest upstream changes (presumably #411) made this pull request unmergeable. Please resolve the merge conflicts.

nical commented 4 years ago

@bors-servo r+

bors-servo commented 4 years ago

:pushpin: Commit 69a373e has been approved by nical

bors-servo commented 4 years ago

:hourglass: Testing commit 69a373e1e262d5c1efb819b345745c45cd9529e9 with merge 6dada4685defb6887f77c63edc192dea111c8a1b...

bors-servo commented 4 years ago

:sunny: Test successful - checks-travis Approved by: nical Pushing 6dada4685defb6887f77c63edc192dea111c8a1b to master...