search

servo / euclid

Geometry primitives (basic linear algebra) for Rust
Other
458 stars 102 forks source link

(breaking change) Fix backward rotation #413

Closed nical closed 4 years ago

nical commented 4 years ago

Fixes #354

I am putting this here for the next breaking change since it's a pretty important one. Let's wait until we have all of the planned breaking changes before landing this.

My main worry with this was that code would silently break upon updating with things rotating the other way around so I renamed create_foo transform constructors into foo, to force users to go over call sites upon updating. The upside is that IMHO the new names are nicer.

bors-servo commented 4 years ago

:umbrella: The latest upstream changes (presumably #427) made this pull request unmergeable. Please resolve the merge conflicts.

nical commented 4 years ago

r? @kvark

nical commented 4 years ago

@bors-servo r=kvark

bors-servo commented 4 years ago

:pushpin: Commit 1e23558 has been approved by kvark

bors-servo commented 4 years ago

:hourglass: Testing commit 1e2355823065b59c5b249f6fb483e2df7768e314 with merge a271399760090e5b9ef3b9fba81f8c18cb8e0162...

bors-servo commented 4 years ago

:sunny: Test successful - checks-travis Approved by: kvark Pushing a271399760090e5b9ef3b9fba81f8c18cb8e0162 to master...