(breaking change) Move away from pre_transform/post_transform terminology

servo / euclid

Geometry primitives (basic linear algebra) for Rust

Other

462 stars 102 forks source link

Closed nical closed 4 years ago

nical commented 4 years ago

Rename post_transform into then.
Remove pre_transform (a.pre_transform(b) can trivially be rewritten as b.then(a)).
Rename Transform2D and Transform3D's post_translate, post_rotate, etc. into then_translate etc.

Keep pre_translate and similar methods on Transform2D and Transform3D as they are still useful and IMO unambiguous.

nical commented 4 years ago

cc @Manishearth

Manishearth commented 4 years ago

What about the row_major/column_major constructors?

nical commented 4 years ago

What about the row_major/column_major constructors?

Coming in the next PR. r?

nical commented 4 years ago

@bors-servo r=Manishearth

bors-servo commented 4 years ago

:pushpin: Commit 2d1aebf has been approved by Manishearth

bors-servo commented 4 years ago

:hourglass: Testing commit 2d1aebf5a52ebd45f7043b69db2c4ddf58a8da20 with merge 4b2863a7ec6954b3f011bb0f20d65bdb73abb2bc...

bors-servo commented 4 years ago

:sunny: Test successful - checks-travis Approved by: Manishearth Pushing 4b2863a7ec6954b3f011bb0f20d65bdb73abb2bc to master...