(breaking change) Replace Scale::ONE with Scale::identity

servo / euclid

Geometry primitives (basic linear algebra) for Rust

Other

462 stars 102 forks source link

(breaking change) Replace Scale::ONE with Scale::identity #457

Closed nical closed 4 years ago

nical commented 4 years ago

ONE was only implemented for f32 (I think nothing else in euclid has a functionality implemented for a single type) whereas identity is implemented for all types implementing num::One. On the other hand identity can't be a const fn because these don't support trait bounds other than Sized currently. Also identity is consistent with other transform types in euclid.

nical commented 4 years ago

@bors-servo r=kvark

bors-servo commented 4 years ago

:pushpin: Commit 630dfca has been approved by kvark

bors-servo commented 4 years ago

:hourglass: Testing commit 630dfca2e7bb266f03127ef167a11db8bb01c9f8 with merge 811605a1ee5f5a1016d4b7746f75b0bc2b1e1934...

bors-servo commented 4 years ago

:sunny: Test successful - checks-travis Approved by: kvark Pushing 811605a1ee5f5a1016d4b7746f75b0bc2b1e1934 to master...