servo / euclid

Geometry primitives (basic linear algebra) for Rust
Other
462 stars 103 forks source link

Point2D/Point3D missing Add<Point2D<T, U>> impl #504

Closed ua-kxie closed 11 months ago

ua-kxie commented 11 months ago

Hello,

I noticed that Point2D/3D have Sub<Point2D<T, U>> and Sub<Point3D<T, U>>, but neither have the Add equivalent. (or subAssign/addAssign for that matter)

Is this a conscious design choice? If so, what is the reasoning behind it? If not, I'd like to work on a PR for this

ua-kxie commented 11 months ago

lol just realized that it produces a vec not another point