and this does not reflect the actual calculation, because Transform2D does not transform Point3D or Vector3D, so the w component in the result is always 1.
Furthermore, all matrices are transposed in the Transform2D or Transform3D documentation. Although it is mentioned that Transform2D or Transform3D use column-major order, I think putting transposed matrices without the transpose symbol is counter-intuitive for readers.
At least the following code must be represented as below.
In the doc-comment of
Transform2D
, there is a matrix formula that describes the transformation performed byTransform2D
:https://github.com/servo/euclid/blob/6b2aece8d8bdd3e872603a3fe07d6bc438ae3d24/src/transform2d.rs#L51-L55
and this does not reflect the actual calculation, because
Transform2D
does not transformPoint3D
orVector3D
, so thew
component in the result is always 1.Furthermore, all matrices are transposed in the
Transform2D
orTransform3D
documentation. Although it is mentioned thatTransform2D
orTransform3D
use column-major order, I think putting transposed matrices without the transpose symbol is counter-intuitive for readers.At least the following code must be represented as below.
https://github.com/servo/euclid/blob/6b2aece8d8bdd3e872603a3fe07d6bc438ae3d24/src/transform2d.rs#L546-L554