glyph_for_char return None when the given char does not exit on Windows

servo / font-kit

A cross-platform font loading library written in Rust

Apache License 2.0

678 stars 100 forks source link

Closed Hankszhang closed 4 years ago

Hankszhang commented 4 years ago

glyph_for_char on Windows will always return Some(0) when the given char does not exit, It seems return None is more reasonable

jdm commented 4 years ago

@bors-servo r+

bors-servo commented 4 years ago

:pushpin: Commit cb1fc0e has been approved by jdm

bors-servo commented 4 years ago

:hourglass: Testing commit cb1fc0eb3b1b34aa3f50ae1da53d0b61e0d584a2 with merge 63d319cb2e619f1b4e4c1d1db533bbdc49044cea...

bors-servo commented 4 years ago

:sunny: Test successful - checks-travis Approved by: jdm Pushing 63d319cb2e619f1b4e4c1d1db533bbdc49044cea to master...