search

servo / font-kit

A cross-platform font loading library written in Rust
Apache License 2.0
678 stars 100 forks source link

Optimize(MacOS): create handle #183

Closed xiaopengli89 closed 3 years ago

xiaopengli89 commented 3 years ago
  1. create_handles_from_core_text_collection: We can cache font analyze result, so the data of same path just be analyzed at first time.
  2. create_handle_from_descriptor: We should handle the error. Call analyze_path and slurp_file will read file twice.
jdm commented 3 years ago

@bors-servo r+ These changes look reasonable. Thanks!

bors-servo commented 3 years ago

:pushpin: Commit 4b38dc6 has been approved by jdm

bors-servo commented 3 years ago

:hourglass: Testing commit 4b38dc6ccb3ac76d36a85fc564ec5f293b2195fe with merge e157b3c4b591969854121d0687f1f564854c856a...

bors-servo commented 3 years ago

:sunny: Test successful - checks-travis Approved by: jdm Pushing e157b3c4b591969854121d0687f1f564854c856a to master...