cpearce
commented
6 years ago - Adds NetworkResource trait.
- Adds play/pause toggle (Space) and Seek ('S') key press handlers.
- Adds naive implementation of the NetworkResource trait to the example player, using Hyper. This caches data it receives until a seek into an unbuffered range, whereupon it discards all cached data, starts a new HTTP Byte Range Request, and caches everything from then onwards until the next seek into an unbuffered range. This should be a lot smarter in a production implementation.
- The NetworkResource trait is called by Gecko on the media decode thread pool threads. This means that every time we call one of the functions, it can be on a different C++ thread. Implementations will need to be mindful of this. I've made the functions on the interface immutable in order to help guide implementors towards a safe implementation. If this proves problematic, we could change GeckoMedia to instead export a pub enum for the network actions we need instead of the trait, and require clients to pass in a Sender<> for that enum which is connected to a handler for all those types.
nox
bors-servo