cpearce
commented
6 years ago - Fix rendering so that we render frames taking into account the Pixel Aspect Ratio. This means videos render at the correct size, rather than at the size of the video frames.
- Check for window resize on every frame. On MacOS we don't get resize event from glutin, so this change makes us render correctly after a resize.
- We still don't handle painting during a resize on MacOS (between mouse-down and mouse-up). That's much more complicated to get working.
- Fix a shutdown crash; if I quit while playing back, I was getting an assert in the threading code while trying to deallocate video frames. The problem was were were dropping the frames from Rust code after the gecko-media Player had been shutdown which confused the threading safety checks. So now each ImageContainer tracks what frames it's exported into Rust code, and when it shuts down it deallocates those frames. The objects still exported to Rust will be neutered, so we won't crash when Rust tries to drop them after GeckoMedia has shutdown.
philn
bors-servo