servo / gecko-media

Firefox's media playback stack in a stand alone Rust crate
Mozilla Public License 2.0
6 stars 9 forks source link

Example player playback position and buffered UI #117

Closed cpearce closed 6 years ago

cpearce commented 6 years ago
cpearce commented 6 years ago

@nox r?

nox commented 6 years ago

r=me with the trait removed or renamed.

bors-servo commented 6 years ago

:umbrella: The latest upstream changes (presumably #114) made this pull request unmergeable. Please resolve the merge conflicts.

cpearce commented 6 years ago

@nox using an inherent function isn't working:

error[E0116]: cannot define inherent impl for a type outside of the crate where the type is defined --> src/bin/test-player.rs:276:1 276 / impl LayoutPrimitiveInfo { 277 pub fn to(&self, x2: i32, y2: i32) -> LayoutRect { 278 LayoutRect::new( 279 LayoutPoint::new(self.0 as f32, self.1 as f32), ... 282 } 283 } _^ impl for type defined outside of crate.
= note: define and implement a trait or new type instead

error: aborting due to previous error

Is there some other way this can be made to work?

nox commented 6 years ago

I had assumed that LayoutPrimitiveInfo was our own type, sorry. Let's just merge it as is, r=me once it's rebased.

cpearce commented 6 years ago

@bors-servo r=nox

bors-servo commented 6 years ago

:pushpin: Commit 1543745 has been approved by nox

bors-servo commented 6 years ago

:hourglass: Testing commit 1543745458274db0f3f023044b14cb5aaf9805c2 with merge ecb0cc7bfdf9629e550f6d13962c7f8f780a0d0c...

bors-servo commented 6 years ago

:sunny: Test successful - status-travis Approved by: nox Pushing ecb0cc7bfdf9629e550f6d13962c7f8f780a0d0c to master...