search

servo / gecko-media

Firefox's media playback stack in a stand alone Rust crate
Mozilla Public License 2.0
6 stars 9 forks source link

Avoid duplicating symbols between mozjs and gecko-media. #118

Closed jdm closed 6 years ago

jdm commented 6 years ago

This fixes https://github.com/servo/servo/issues/19348, by avoiding the violations of the one definition rule caused by linking mozjs's mfbt in with gecko-media's copy.

ferjm commented 6 years ago

@bors-servo r+ Thanks!

bors-servo commented 6 years ago

:pushpin: Commit a3aa795 has been approved by ferjm

bors-servo commented 6 years ago

:hourglass: Testing commit a3aa7953effeee8be2ecc6b4d86488610fc1b245 with merge fe437442729cfa703b7f40407b449d5373774778...

bors-servo commented 6 years ago

:sunny: Test successful - status-travis Approved by: ferjm Pushing fe437442729cfa703b7f40407b449d5373774778 to master...