Cached ranges sink and update Gecko - Githubissues

servo / gecko-media

Firefox's media playback stack in a stand alone Rust crate

Mozilla Public License 2.0

6 stars 9 forks source link

Cached ranges sink and update Gecko #122

Closed cpearce closed 6 years ago

cpearce commented 6 years ago

Currently GeckoMedia has no way to know when the byte ranges which the NetworkResource has cached has changed. So pass a CachedRangesSink struct to the NetworkResource, which it can use to send GeckoMedia the new cached byte ranges when they change.
Use the CachedRangesSink in the example player. This now renders the byte ranges buffered in its UI.
Update Gecko. I was able to move a bunch of files out of glue and into pure export, and I updated the other glue files to more closely match upstream.

nox commented 6 years ago

The Rust code looks ok to me, @cpearce.

philn commented 6 years ago

Ok! @bors-servo r+

bors-servo commented 6 years ago

:pushpin: Commit 31b5345 has been approved by philn

bors-servo commented 6 years ago

:hourglass: Testing commit 31b53450096367387e3b0eea6ffcdaa62216e710 with merge 498a186b1021ee75c82916fe73fe5dfe6050e6eb...

bors-servo commented 6 years ago

:broken_heart: Test failed - status-travis

philn commented 6 years ago

Travis is so slow ... @bors-servo r+

bors-servo commented 6 years ago

:bulb: This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

bors-servo commented 6 years ago

:pushpin: Commit 31b5345 has been approved by philn

bors-servo commented 6 years ago

:hourglass: Testing commit 31b53450096367387e3b0eea6ffcdaa62216e710 with merge 165997f62f271cd02f44702631b5effd8b3d8655...

bors-servo commented 6 years ago

:sunny: Test successful - status-travis Approved by: philn Pushing 165997f62f271cd02f44702631b5effd8b3d8655 to master...