search

servo / gecko-media

Firefox's media playback stack in a stand alone Rust crate
Mozilla Public License 2.0
6 stars 9 forks source link

Ensure video frames are stored in Rust allocated memory #131

Closed cpearce closed 6 years ago

cpearce commented 6 years ago

To resolve the problems in issue #112 and to remove the potential use-after-free which can happen if GeckoMedia shuts down and deallocates video frames before the compositor is finished painting video frames, switch to having the video frames stored in Rust allocated Vecs which are ref counted. This means we won't deallocate the memory until the last Rust or C++ user of the data is destroyed.

cpearce commented 6 years ago

@bors-servo r=philn

bors-servo commented 6 years ago

:pushpin: Commit 5ee2696 has been approved by philn

bors-servo commented 6 years ago

:hourglass: Testing commit 5ee2696ec1f36d94e6d778ef9f6a221e5575aaf2 with merge d7dcfce582a1b952ee9e4e53302149d1e8823595...

bors-servo commented 6 years ago

:sunny: Test successful - status-travis Approved by: philn Pushing d7dcfce582a1b952ee9e4e53302149d1e8823595 to master...