search

servo / gecko-media

Firefox's media playback stack in a stand alone Rust crate
Mozilla Public License 2.0
6 stars 9 forks source link

Test player does not render any frame on OSX #138

Open ferjm opened 6 years ago

ferjm commented 6 years ago

All I see is an empty application window when running the test player on OSX.

The output says: Rendered 0 frames in 5.934178627001529 seconds; 0 fps.

screen shot 2017-12-28 at 16 56 37

I believe the regression was introduce with #131 as reverting to a previous commit makes everything work as expected.

cpearce commented 6 years ago

This is caused by to_ffi_planar_ycbycr_images() failing to retrieve a buffer for video frames because I forgot to include the "return" keyword in my definition of RustBufferAllocator::Allocate(). Yay unsafe code.