search

servo / gecko-media

Firefox's media playback stack in a stand alone Rust crate
Mozilla Public License 2.0
6 stars 9 forks source link

MP3, Ogg/Vorbis and Flac playback #54

Closed philn closed 6 years ago

philn commented 6 years ago

In this PR the MP3 decoder and demuxer are imported from Gecko. I validated by locally modifying the wav playback test with an mp3 file. Same for Ogg/Vorbis and Flac support.

philn commented 6 years ago

@bors-servo try

bors-servo commented 6 years ago

:hourglass: Trying commit 3ed7a794d0245780a5142d6c98b546e7cfc47b65 with merge d40ca113eafff5a12af06b4f62d21391020cf2af...

cpearce commented 6 years ago

We should have tests, like what we have for the WAV support, that tests that we can play these formats. They should not be in a separate player app, they should be in our test suite here.

cpearce commented 6 years ago

@bors-servo r=cpearce

bors-servo commented 6 years ago

:pushpin: Commit 520c282 has been approved by cpearce

bors-servo commented 6 years ago

:hourglass: Testing commit 520c282e332e2a7dfdc39a096ddf8d78dca3946a with merge f861c36f75ad87ef8ed64c8133619dd8c08d6f1e...

bors-servo commented 6 years ago

:sunny: Test successful - status-travis Approved by: cpearce Pushing f861c36f75ad87ef8ed64c8133619dd8c08d6f1e to master...