cpearce
commented
7 years ago - Adds and connects a few more callbacks, timeupdate, seeking callbacks, loadeddata, and duration change.
- Using what's added here, it should be possible to implement basic play/pause/seek in Servo with HTMLMediaElement.currentTime reporting the playback position as notified by the PlayerEventSink::time_update() callback.
- Refactored tests to also include a seek test.
- Duration is now reported only via callbacks, it can't be queried directly. I was concerned that the previous method of querying duration is dangerous as it requires blocking the calling (script) thread and waiting on a task to run on the Gecko "main" thread, which could take an unknown amount of time to clear its event queue. So we now rely on GeckoMedia telling us the duration when it reaches loadedmetadata and also notifying if the duration changes.
- Adds basic rustdoc comments to pub structs.
nox
bors-servo
edunham