search

servo / gecko-media

Firefox's media playback stack in a stand alone Rust crate
Mozilla Public License 2.0
6 stars 9 forks source link

TimeStamp binding #73

Closed philn closed 6 years ago

philn commented 6 years ago

Image timestamps are now passed to Rust world as monotonic u64 values expressing time in nanoseconds.

philn commented 6 years ago

@nox asked me to rewire the logic so that Rust calls Gecko instead of the other way around but this doesn't seem trivial because owningImage->mTimeStamp is sometimes(?) lower than TimeStamp::Now() (that means the frame has to be dropped i suppose). So it triggers signed / unsigned issues on Rust side.

nox commented 6 years ago

@philn I meant that GeckoMedia_Rust_TimeNow should probably be a function pointer fed by the Rust side to the C++ side. But you are free to not make that change if that's too convoluted.

cpearce commented 6 years ago

@bors-servo r=cpearce

bors-servo commented 6 years ago

:pushpin: Commit 07d4804 has been approved by cpearce

bors-servo commented 6 years ago

:hourglass: Testing commit 07d48047d717da5f6cbc995aa09bbb3c57a0c6e7 with merge fabc7d9ac7bfad7b40335c6c2b6a14cd978893a0...

cpearce commented 6 years ago

@bors-servo retry

bors-servo commented 6 years ago

:umbrella: The latest upstream changes (presumably #75) made this pull request unmergeable. Please resolve the merge conflicts.

philn commented 6 years ago

@bors-servo r=cpearce

bors-servo commented 6 years ago

:pushpin: Commit 202bc84 has been approved by cpearce

bors-servo commented 6 years ago

:hourglass: Testing commit 202bc8447267fec506b1c42ca50fcfcc24e02fe5 with merge 648a852ef74a39afd8a48ef30f99413565aff3ef...

bors-servo commented 6 years ago

:sunny: Test successful - status-travis Approved by: cpearce Pushing 648a852ef74a39afd8a48ef30f99413565aff3ef to master...